Versions Compared

Old Version 2

changes.mady.by.user Former user

Saved on

compared with

New Version 3

changes.mady.by.user Former user

Saved on

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

5.2.4 / 2017-12-11

...

CategoryIssueIssue DescriptionNotes
ImprovementPRAC-1733Remove P4B exam file when exam is reset
  • When exam is published exam json file is created on server
    • After exam is reset file is deleted from serverWhen a Pratique for Browser (P4B) exam is reset, the exam file is left on the drive. This is not necessary because the exam cannot be used anymore and only occupies disk space.    		The fix means that the P4B exam file is removed when an exam is reset, published or locked. 
    Improvement
    		Changed email to admins to be a email list instead of addressesI have checked on test.master.practique.net and it is set to Practique Admins in conf/project_settings.py
    ImprovementPRAC-1710
    1. Reverting instance_cache for diet.state as it causes problems when change is propagated through signals. The code see old value eg on session.set_complete
    2. Speed up exam list (at least 2x)
  • I can confirm that "instance_cache" decorator is removed from deits/models.py and template is adjusted accordingly.
  • I am not able to compare this on test.master 5.2.4-rc.1 instance but there were 27 exams and they were listed in less then 3 seconds
    • I have tested locally some old branch with 27 exams little bit less then 3 seconds and the 5.2.x branch 34 exams for little bit more then 1 secSpeed improvement
    ImprovementPRAC-1683Added an option to allow import Items items imported from a CSV file but leave them in Draft stateAutomatically approve imported items is working.to be left in a draft state. Previously, all items imported were automatically approved unless the import failed. 
    ImprovementPRAC-1712Pass fail The candidate feedback report is now configurable. The Pass/Fail on Written and OSCE feedback report can be turned on and off in the report configuration"Include pass/fail" checkbox is present in the report configuration form.
    ImprovementPRAC-1713Improved combined exams setup and validationTried . Previously, it was possible to combine any kind of exam blocks together. If incompatible blocks were merged together, the result did not make any sense. This improvement means that it now impossible to combine such exams. 

    If the user tries to combine two unrelated OSCE unrelated exam blocks and I wasn't allowed by Practique. It was using different candidates and stations. After clicking on "Verify" I got popup window preventing me doing that.Image Removed, Practique will now prevent this. 

    Image Added

    ImprovementPRAC-1705

    Results download improvements

    1. Set standard - Download results as CSV is much faster now
    2. Improved speed of candidate result CSV download

    Downloading results for 30 items 2 sessions per 30 candidates from Standard page went 8 sec.

    Downloading results for 30 items 1 session 60 candidates from Standard page went 9 sec

    This is very close to what Radim has tested and got on his test insgtance with 40 items and 320 candidates

    Fixes

    CategoryIssueIssue DescriptionNotes
    Bug fixPRAC-1732Fix for unhandled error raised when new answer is added to VSAQ/Anatomy case

    I was able to change value of a VSAQ response and add new response to VSAQ question without crash on 5.2.4-rc.1 on test.master even if answer contained unicode characters from P4B.


    Bug fixPRAC-1727Fix for unicode answers coming from P4B client (marks were lost but can be recovered)

    Marks are not lost anymore. I got marks correctly on view marks page for the particular SBA answer that contained unicode characters.

    Bug fixPRAC-1720If item set is replaced in a scheduled exam, make sure new version of item in the itemset does replace it's previous vesion in scheduled rotation.

    I have created exam with 10 OSCE stations and followed the bug reporducing steps.

    1. Ordering after updating items in the item set has not changed
    2. Ordering of items on "View Rotations: has not changed
    3. Ordering on "Visit starting rooms" has not changed
    Bug fixPRAC-1725Prevent duplicate item in an item set on double clickIt is not possible to add more then one item to item set if quickly clicking on "Add" button anymore.
    Bug fixPRAC-1718Fixed bug that allowed duplicated items in item set if there were multiply versions of an itemIt is not possible to add duplicated items with new version to item set. anymore. It is possible only to "Update items".
    Bug fix
    		Fix URL to dicom.cssThere is no more error in browser's inspector about dicom.css missing
    Bug fixPRAC-1715Use mimetypes module to detect correct mime type of downloaded file. It's needed on Apache only

    In Chrome version 62.0.3202.94 it possible to dowload the report

    Firefox 55.0.3

    Safari 11.0.1

    Bug fixPRAC-1716If no items are found during item set generator, the task was not finished successfully

    If no items were found we get the message that "0 items found"

    And on celery server log we get that task has finished successfully.

    Bug fixPRAC-1714Fix for file with a name containing unicode characters uploaded to item resources. It was not possible to download it back in some casesWhen clicking on "Download" button in Chrome 62.0.3202.94, Firefox 55.0.5 and Safari 11.0.1 it opens the file in browser's built in PDF viewer without any errors.
    Bug fixPRAC-1709Fixed P4B backend url handler (disabled if P4B is not available)

    If "practique.app.apps.AppAppConfig" is not added to django settings INSTALLED_APPS, then we get 404 page Not found

    Otherwise if it is set exam file is generated in media/exams folder.

    Bug fixPRAC-1708Fix for a bug in VSAQ mark value change which caused wrong max score on markitems

    After I changed the score value of the response to lower then item's max score, it didn't changed the max score value of an item.

    When from Standard setting page we go to Item list page it shows the max score as it was set during the item creation.

    The audit log has been created, and I could see the audit log of the changed mark value on the candidate mark's page.

    Bug fixPRAC-1707Fixed order of items displayed on Candidate Edit marks page (Written)

    If exam has randomized questions the order of items on edit marks page is according to that candidate's order (by Interview.round number).

    Radim Novotny can you please check this if I understood it correctly?

    Bug fixPRAC-1701Fix for session schedule/rotation page if there is no circuit number 1

    I'm not 100% sure if I understood the problem here.

    I was checking PSD issue related to this and checked the LKC server as well. It seems to me that because they have 2 candidates less then 54 they couldn't see the rotation.

    I have tried to reporduce it with small 10 OSCE station situation and didn't assign Circuit 1 for two station and I could see the rotation when I locked the exam. Although I got worning message on Role player settings.

    Radim Novotny Can you please check my description if it is correct?

    Bug fixPRAC-1702
    1.  Added /status?format=ping to help session timeout reset and avoid problem with response code 500
    2. Logout user from SSO if session inactivity logout is issued.

    This was tested with SSO account on pepik.practique.net with 5.2.4-rc.1 since test.master has no SSO settings (Radim).

    Robert: I was able to login to pepik.practique.net and after 2 minutes of inactivity pop modal window showed warning me that if I don't close that window in 60 secs I will have to login back again.

    Bug fixPRAC-1699If user account is turned into SSO only or back to real account. handle the password properly

    On test.master.practique.net I have set SSO settings in settings file and created new user with SSO only login.

    I have checked in the django admin and the password was not set.

    Then turned that user as regular Practique user and in Django admin I could see that password was created.

    Then changed that user again as SSO only and in Django admin password was removed.


    Bug fixPRAC-1648Can't search for item set by IDWhen preparing exam and adding Item set to exam when clicking "Add Item Set to this list" button in the form it is possible now to search for Item set by ID (palette_number), it is not searching by "pk" anymore.

    ...